misc: add openlane #246

proppy · 2022-09-27T15:01:01Z

Fixes #244

ajelinski

Apart from needs I see such logs:

https://github.com/hdl/conda-eda/actions/runs/3136689055/jobs/5093922644#step:4:1726

  OpenLane UNKNOWN
  (with mounted scripts from fatal: not a git repository: '$PREFIX/share/openlane/.git')
  All rights reserved. (c) 2020-2022 Efabless Corporation and contributors.
  Available under the Apache License, version 2.0. See the LICENSE file for more details.
  
  Warning: : OpenLane may not function properly: not enough values to unpack (expected 3, got 1)

https://github.com/hdl/conda-eda/actions/runs/3136689055/jobs/5093922644#step:4:1809

.../openlane/designs/inverter/runs/RUN_2022.09.27_15.06.12/results/signoff/inverter.klayout.gds' wasn't found. Skipping GDS XOR.

Did you see them, are those acceptable? Otherwise LGTM.

.github/workflows/Build.yml

proppy · 2022-10-18T12:53:55Z

OpenLane UNKNOWN
(with mounted scripts from fatal: not a git repository: '$PREFIX/share/openlane/.git')

Maybe we could patch https://github.com/The-OpenROAD-Project/OpenLane/blob/32da932761213af689f10088d671e1e3dc38f273/flow.tcl#L395-L398 so that it include the conda version?

.../openlane/designs/inverter/runs/RUN_2022.09.27_15.06.12/results/signoff/inverter.klayout.gds' wasn't found. Skipping GDS XOR.

We should probably set RUN_KLAYOUT_XOR=0 in misc/openlane/disable-missing-tools.tcl so that it get skilled:
https://github.com/The-OpenROAD-Project/OpenLane/blob/32da932761213af689f10088d671e1e3dc38f273/flow.tcl#L151

ajelinski · 2022-10-18T13:08:16Z

Maybe we could patch https://github.com/The-OpenROAD-Project/OpenLane/blob/32da932761213af689f10088d671e1e3dc38f273/flow.tcl#L395-L398 so that it include the conda version?

Perhaps adding echo $PKG_VERSION >$PREFIX/share/openlane/install/installed_version to build.sh could be enough thanks to: https://github.com/The-OpenROAD-Project/OpenLane/blob/32da932761213af689f10088d671e1e3dc38f273/flow.tcl#L381

proppy · 2022-10-18T13:31:21Z

Perhaps adding echo $PKG_VERSION >$PREFIX/share/openlane/install/installed_version to build.sh could be

Yes figured this out too with ac16102 but I think we also need The-OpenROAD-Project/OpenLane#1439.

proppy · 2022-10-18T13:37:05Z

@ajelinski what do you think of bundling tcllib like I'm doing in https://github.com/proppy/conda-eda/tree/master/misc/tcllib ? would you prefer to have this as a separate PR?

ajelinski · 2022-10-18T13:59:02Z

@ajelinski what do you think of bundling tcllib like I'm doing in https://github.com/proppy/conda-eda/tree/master/misc/tcllib ? would you prefer to have this as a separate PR?

I have no problem with including it in this PR as such.

I don't know tcl very well, is tcllib OS-independent? Shouldn't it be actually built with conda-build?

proppy · 2022-10-18T15:13:47Z

I don't know tcl very well, is tcllib OS-independent? Shouldn't it be actually built with conda-build?

There is actually a conda-forge package we could backport: https://github.com/conda-forge/tcllib-feedstock

Looking at the underlying installer it seems that it's mostly copying files around: https://core.tcl-lang.org/tcllib/file?name=installer.tcl&ci=tip so I'm not sure why it's not noarch https://anaconda.org/conda-forge/tcllib/files

ajelinski · 2022-10-19T10:19:12Z

There is actually a conda-forge package we could backport: https://github.com/conda-forge/tcllib-feedstock

Looking at the underlying installer it seems that it's mostly copying files around: https://core.tcl-lang.org/tcllib/file?name=installer.tcl&ci=tip so I'm not sure why it's not noarch https://anaconda.org/conda-forge/tcllib/files

I'll "build" and upload the tcllib package from a branch then and move the package on the litex-hub channel to main. IMO adding it to the repository to have it built nightly doesn't make sense in such a case especially that the source doesn't change at all.

Perhaps it isn't noarch because it has the tk package in run requirements? Not sure but maybe let's keep it as it is especially that we only need the package for Linux, WDYT?

proppy · 2022-10-19T11:10:48Z

I'll "build" and upload the tcllib package from a branch then and move the package on the litex-hub channel to main.

Oh I didn't realize you had upload write to anaconda main! I'll keep this in mind for other commonly used package that are only in conda-forge.

Perhaps it isn't noarch because it has the tk package in run requirements?

Ah that would make sense, looking at the various module documentation it seems that only only few package depends on Tk:
https://github.com/tcltk/tcllib/search?q=%22%5Brequire+Tk%22+titledesc:

map
comm
tepam
math

Looking at the installer it seems that there is a +excluded flag https://github.com/tcltk/tcllib/blob/efe4404da89b4bd7adafeadd4106a1a4592492ab/installer.tcl#L474 we could leverage to remove them (or we could patch out the part that depends on tk). I'm not familiar with the main requirement and that might be moot since tk looks already well packaged: https://anaconda.org/main/tk

ajelinski · 2022-10-19T14:22:48Z

Oh I didn't realize you had upload write to anaconda main! I'll keep this in mind for other commonly used package that are only in conda-forge.

Oh no, I'm not that powerful. :-) I only meant moving the package from the ci-<branch>-<run_id> to the main Conda label. It only makes the package built by CI from a conda-eda branch "visible" without providing the label name (because main is the default label).

Ah that would make sense, looking at the various module documentation it seems that only only few package depends on Tk: https://github.com/tcltk/tcllib/search?q=%22%5Brequire+Tk%22+titledesc:
* map

* comm

* tepam

* math
Looking at the installer it seems that there is a +excluded flag https://github.com/tcltk/tcllib/blob/efe4404da89b4bd7adafeadd4106a1a4592492ab/installer.tcl#L474 we could leverage to remove them (or we could patch out the part that depends on tk). I'm not familiar with the main requirement and that might be moot since tk looks already well packaged: https://anaconda.org/main/tk

Is having a noarch package worth such a struggle?

I've just made the tcllib package for Linux available on the LiteX-Hub channel so please test it and modify this package to use it.

proppy · 2022-10-19T14:32:18Z

Is having a noarch package worth such a struggle?

Not really, but it also allow us to remove the transitive dependencies on tk for openlane :)

proppy · 2022-10-19T14:39:10Z

I've just made the tcllib package for Linux available on the LiteX-Hub channel so please test it and modify this package to use it.

Done.

proppy · 2022-10-19T14:47:49Z

Not really, but it also allow us to remove the transitive dependencies on tk for openlane :)

Filed #250 (comment) so that we can explore this separatly.

.github/workflows/Build.yml

proppy · 2022-10-20T01:30:27Z

squash the commits.

Done.

ajelinski · 2022-10-20T08:36:25Z

Unfortunately the build failed -- there's something wrong with the patch @proppy

Co-authored-by: Adam Jeliński <59468166+ajelinski@users.noreply.github.com>

proppy · 2022-10-20T08:45:00Z

Unfortunately the build failed -- there's something wrong with the patch @proppy

refreshed the patch

misc/openlane/1439.patch

Co-authored-by: Adam Jeliński <59468166+ajelinski@users.noreply.github.com>

proppy · 2022-10-25T07:36:22Z

@ajelinski curious why the CI still fails?

ajelinski · 2022-10-25T07:38:36Z

The patch was merged upstream yesterday. I've just merged and removed the patch. :)

proppy mentioned this pull request Sep 27, 2022

Add constructor based installer #247

Open

ajelinski approved these changes Oct 18, 2022

View reviewed changes

.github/workflows/Build.yml Show resolved Hide resolved

proppy mentioned this pull request Oct 18, 2022

flow: skip mounted version for local install The-OpenROAD-Project/OpenLane#1439

Merged

proppy mentioned this pull request Oct 19, 2022

remove gui dependencies when applicable #250

Open

ajelinski reviewed Oct 19, 2022

View reviewed changes

.github/workflows/Build.yml Outdated Show resolved Hide resolved

proppy force-pushed the add-openlane branch from 637cd44 to 968ef47 Compare October 20, 2022 01:29

proppy requested a review from ajelinski October 20, 2022 01:30

misc: add openlane

9b651bf

Co-authored-by: Adam Jeliński <59468166+ajelinski@users.noreply.github.com>

proppy force-pushed the add-openlane branch from 968ef47 to 9b651bf Compare October 20, 2022 08:44

ajelinski reviewed Oct 24, 2022

View reviewed changes

misc/openlane/1439.patch Outdated Show resolved Hide resolved

misc/openlane/1439.patch: fix header

7449f9e

Co-authored-by: Adam Jeliński <59468166+ajelinski@users.noreply.github.com>

ajelinski merged commit eec67d8 into hdl:master Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc: add openlane #246

misc: add openlane #246

proppy commented Sep 27, 2022 •

edited

Loading

ajelinski left a comment •

edited

Loading

proppy commented Oct 18, 2022

ajelinski commented Oct 18, 2022

proppy commented Oct 18, 2022

proppy commented Oct 18, 2022

ajelinski commented Oct 18, 2022

proppy commented Oct 18, 2022

ajelinski commented Oct 19, 2022

proppy commented Oct 19, 2022

ajelinski commented Oct 19, 2022 •

edited

Loading

proppy commented Oct 19, 2022

proppy commented Oct 19, 2022

proppy commented Oct 19, 2022

proppy commented Oct 20, 2022

ajelinski commented Oct 20, 2022

proppy commented Oct 20, 2022

proppy commented Oct 25, 2022

ajelinski commented Oct 25, 2022

misc: add openlane #246

misc: add openlane #246

Conversation

proppy commented Sep 27, 2022 • edited Loading

ajelinski left a comment • edited Loading

Choose a reason for hiding this comment

proppy commented Oct 18, 2022

ajelinski commented Oct 18, 2022

proppy commented Oct 18, 2022

proppy commented Oct 18, 2022

ajelinski commented Oct 18, 2022

proppy commented Oct 18, 2022

ajelinski commented Oct 19, 2022

proppy commented Oct 19, 2022

ajelinski commented Oct 19, 2022 • edited Loading

proppy commented Oct 19, 2022

proppy commented Oct 19, 2022

proppy commented Oct 19, 2022

proppy commented Oct 20, 2022

ajelinski commented Oct 20, 2022

proppy commented Oct 20, 2022

proppy commented Oct 25, 2022

ajelinski commented Oct 25, 2022

proppy commented Sep 27, 2022 •

edited

Loading

ajelinski left a comment •

edited

Loading

ajelinski commented Oct 19, 2022 •

edited

Loading