Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace data_utils.get_shape with utils.get_data_shape #204

Closed
rly opened this issue Nov 18, 2019 · 0 comments · Fixed by #205
Closed

Replace data_utils.get_shape with utils.get_data_shape #204

rly opened this issue Nov 18, 2019 · 0 comments · Fixed by #205
Labels
category: enhancement improvements of code or code behavior

Comments

@rly
Copy link
Contributor

rly commented Nov 18, 2019

We have two nearly identical methods that get the shape of a data type -- one in data_utils and one in utils for docval.

Replace the former with the latter, which covers more cases than the former. Also remove data_utils.__get_shape_helper.
@rly rly added category: enhancement improvements of code or code behavior code maintenance labels Nov 18, 2019
oruebel added a commit that referenced this issue Nov 18, 2019
@oruebel
Removed redundend shape check functions. Fix #204
9c9d3db
@oruebel oruebel mentioned this issue Nov 18, 2019
Merged
5 tasks
oruebel added a commit that referenced this issue Nov 18, 2019
@oruebel
Removed redundend shape check functions. Fix #204 (#205)
c93d595 
* Removed redundend shape check functions. Fix #204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: enhancement improvements of code or code behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed redundend shape check functions. Fix #204 hdmf-dev/hdmf
1 participant
@rly