Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the path for finding the herd zip file. #1046

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Fix the path for finding the herd zip file. #1046

merged 4 commits into from
Jan 29, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jan 29, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Fix #1045

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

pytest

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (d5d6383) to head (3b6fe1b).
Report is 64 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1046   +/-   ##
=======================================
  Coverage   88.52%   88.53%           
=======================================
  Files          45       45           
  Lines        9594     9599    +5     
  Branches     2727     2730    +3     
=======================================
+ Hits         8493     8498    +5     
  Misses        778      778           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review January 29, 2024 18:35
@mavaylon1 mavaylon1 merged commit 825e31f into dev Jan 29, 2024
28 checks passed
@mavaylon1 mavaylon1 deleted the herdpath branch January 29, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: HERD does not generate the paths properly when reading a zip
2 participants