-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write dimension labels to DatasetBuilder on build #1081
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1081 +/- ##
==========================================
+ Coverage 88.83% 88.89% +0.05%
==========================================
Files 45 45
Lines 9784 9833 +49
Branches 2779 2794 +15
==========================================
+ Hits 8692 8741 +49
Misses 776 776
Partials 316 316 ☔ View full report in Codecov by Sentry. |
@@ -15,6 +15,13 @@ class IncorrectQuantityBuildWarning(BuildWarning): | |||
pass | |||
|
|||
|
|||
class IncorrectDatasetShapeBuildWarning(BuildWarning): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these warnings should really be errors because they result in an invalid file. @oruebel what do you think? Should we upgrade all of these warnings to errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All except for DtypeConversionWarning
and the generic BuildWarning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And maybe also the OrphanContainerWarning
.
@rly can you move Otherwise, looks good. |
@mavaylon1 The place to move it would be https://github.com/hdmf-dev/hdmf/blob/dev/tests/unit/helpers/utils.py. However, moving that means also moving the container classes and mappers defined in this file |
TODO: I will look into the coverage failure |
Motivation
Fix #1077
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?