Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Support for Appending References in Hdmf-Zarr #1157

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jul 31, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Add support on the HDMF side for #1125

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@mavaylon1 mavaylon1 self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (50aad2f) to head (7d57787).
Report is 24 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1157   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files          45       45           
  Lines        9833     9834    +1     
  Branches     2794     2794           
=======================================
+ Hits         8741     8742    +1     
  Misses        776      776           
  Partials      316      316           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review July 31, 2024 14:14
@mavaylon1
Copy link
Contributor Author

mavaylon1 commented Jul 31, 2024

Review Notes:
We have full test coverage already with this update. This is the minimum needed to have hdmf-zarr working for appending a Dataset of References. The proxy idea discussed in #1135 will be the full idea. This is being split up so Alessio can get started asap.

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

A general question - should the same support for HDMFDataset and ZarrArray be added to extend_data?

@mavaylon1 mavaylon1 merged commit a98e5e9 into dev Jul 31, 2024
29 checks passed
@mavaylon1 mavaylon1 deleted the zarr_support branch July 31, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants