VectorData Refactor Expandable (#1158) #1180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prior * chckpoint * possible poc * fix * finished tests * dtype * fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix again * fix again * clean up * coverage * Update CHANGELOG.md * Update CHANGELOG.md * Update h5tools.py * Update h5tools.py * clean up for review * clean up for review * clean up --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1180 +/- ##
==========================================
+ Coverage 89.01% 89.03% +0.01%
==========================================
Files 45 45
Lines 9872 9894 +22
Branches 2810 2819 +9
==========================================
+ Hits 8788 8809 +21
Misses 767 767
- Partials 317 318 +1 ☔ View full report in Codecov by Sentry. |
|
@rly This PR is essentially done. I need to go through the pynwb side to make sure what is failing we can ignore through future development. I also want to run the neuroconv tests to make sure those pass as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Fix #1158
Fix #1163
Add expandable default for datasets.
How to test the behavior?
Checklist
CHANGELOG.mdwith your changes?