Fix scalar dataset with compound dtype for export #1185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow up to #1176.
The pynwb roundtrip export tests for
ElectrodeGroupIO
were failing for the scalar compound dataset because on exportoptions[‘dtype’]
was a<class 'numpy.dtype[void]'>
and not a list:hdmf/src/hdmf/backends/hdf5/h5tools.py
Lines 1195 to 1196 in 1abb8ec
Converting the dtype to a list like the non-scalar compound datatypes fixes this and also allows me to revert some changes I had made in the previous PR to the validator.
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?