Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of read h5py string datasets #1189

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Sep 5, 2024

Motivation

Fix #1186.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from stephprince September 5, 2024 22:38
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (044f5a5) to head (9ecdf4f).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1189   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files          45       45           
  Lines        9872     9872           
  Branches     2810     2810           
=======================================
  Hits         8788     8788           
  Misses        767      767           
  Partials      317      317           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince
Copy link
Contributor

Looks good. For the python 3.8 test failures, maybe the string dataset needs to be created differently since that environment uses h5py 2.10?

@rly rly merged commit 874db31 into dev Sep 13, 2024
29 checks passed
@rly rly deleted the fix_multidim_h5py_dataset branch September 13, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in fresh 3.14.4
2 participants