Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DtypeError message for reference validation #1199

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Oct 31, 2024

Motivation

Fix #1055. When validating a reference, the RefSpec input to the DtypeError message initialization was causing an inaccurate error message.

How to test the behavior?

See example file shared in the original matnwb issue.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (6e5534c) to head (2253f0e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1199      +/-   ##
==========================================
+ Coverage   85.62%   89.08%   +3.46%     
==========================================
  Files          45       45              
  Lines        9887     9890       +3     
  Branches     2815     2816       +1     
==========================================
+ Hits         8466     8811     +345     
+ Misses       1076      763     -313     
+ Partials      345      316      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review October 31, 2024 18:34
@rly
Copy link
Contributor

rly commented Oct 31, 2024

Looks good. Thank you @stephprince !

@stephprince stephprince merged commit 06a62b9 into dev Oct 31, 2024
29 checks passed
@stephprince stephprince deleted the fix-dtypeerror-for-refspec branch October 31, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when initializing DtypeError
2 participants