Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error checking for szip H5DataIO settings #168

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Oct 9, 2019

Motivation

Enhance error checking for SZIP parameters in H5DataIO and address suggestions from @rly in #167 that did not make it in before that PR was merged

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style ? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.

@oruebel oruebel requested a review from rly October 9, 2019 19:54
Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Never seen |= used before. Neat!

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #168 into dev will increase coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #168      +/-   ##
==========================================
+ Coverage   70.02%   70.03%   +0.01%     
==========================================
  Files          30       30              
  Lines        5802     5811       +9     
  Branches     1367     1368       +1     
==========================================
+ Hits         4063     4070       +7     
- Misses       1303     1305       +2     
  Partials      436      436
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 63.18% <84.61%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e63b13...2471f85. Read the comment docs.

@oruebel oruebel merged commit 3500458 into dev Oct 15, 2019
@oruebel oruebel deleted the enh/szipchecks branch October 15, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants