Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for the correct types #184

Merged
merged 2 commits into from
Oct 24, 2019
Merged

check for the correct types #184

merged 2 commits into from
Oct 24, 2019

Conversation

ajtritt
Copy link
Contributor

@ajtritt ajtritt commented Oct 24, 2019

Motivation

Fix a bug that was preventing indexing into DynamicTables after read to work properly

@ajtritt ajtritt requested a review from oruebel October 24, 2019 20:44
@bendichter
Copy link
Contributor

aimed to fix NeurodataWithoutBorders/pynwb#1097?

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #184 into dev will decrease coverage by 0.03%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #184      +/-   ##
==========================================
- Coverage   70.31%   70.27%   -0.04%     
==========================================
  Files          30       30              
  Lines        5905     5908       +3     
  Branches     1376     1378       +2     
==========================================
  Hits         4152     4152              
- Misses       1321     1323       +2     
- Partials      432      433       +1
Impacted Files Coverage Δ
src/hdmf/backends/hdf5/h5_utils.py 61.94% <0%> (ø) ⬆️
src/hdmf/common/table.py 53.16% <20%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f049b...15c050b. Read the comment docs.

@ajtritt ajtritt merged commit a85a861 into dev Oct 24, 2019
@rly rly deleted the bug/table_indexing branch January 7, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants