-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance selection of rows in DynamicTable #191
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #191 +/- ##
==========================================
- Coverage 70.27% 70.26% -0.01%
==========================================
Files 30 30
Lines 5920 5946 +26
Branches 1385 1394 +9
==========================================
+ Hits 4160 4178 +18
- Misses 1326 1330 +4
- Partials 434 438 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Looks good to me too |
Thanks @rly @bendichter for reviewing. Now I just need to get a matching PR going for PyNWB to make sure it works with these changes ;-) |
…on works for DynamicTableRegions
@rly can you review this PR again. In addition to the previous changes I had to add the |
Motivation
The goal is to enhance selection of rows from a DynamicTable. This PR makes the following changes:
slice
and add corresponding testsThe matching PR that updates the tests in PyNWB is NeurodataWithoutBorders/pynwb#1106
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number ? By including "Fix #XXX" you allow GitHub to close the corresponding issue.