Fix wrong dict being used for get_carg_spec #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #208 +/- ##
=======================================
Coverage 70.27% 70.27%
=======================================
Files 30 30
Lines 5944 5944
Branches 1395 1395
=======================================
Hits 4177 4177
Misses 1329 1329
Partials 438 438
Continue to review full report at Codecov.
|
ajtritt
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
ObjectMapper.get_carg_specdoes not appear to be used anywhere in HDMF or PyNWB, it is clear from the code and documentation that the wrong dict is referenced in the function. This should be fixed in case the function gets used.