-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing of containers #217
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #217 +/- ##
=========================================
+ Coverage 70.38% 70.4% +0.01%
=========================================
Files 31 31
Lines 5920 5920
Branches 1389 1389
=========================================
+ Hits 4167 4168 +1
+ Misses 1322 1321 -1
Partials 431 431
Continue to review full report at Codecov.
|
A new change: This design pattern is now used in several places, most notably the change from |
assertContainerEqual
does not check that the name, container_source, parent, or children match - just that the other fields (which does not include name!) matches. This PR fixes that.