Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 support, add python 3.9 support #620

Merged
merged 10 commits into from
May 26, 2021
Merged

Drop python 3.6 support, add python 3.9 support #620

merged 10 commits into from
May 26, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented May 26, 2021

Motivation

Python 3.6 end of life is 23 Dec 2021. The latest versions of h5py, numpy, pandas, scipy do not provide wheels for python 3.6. It seems that generally, if a package added 3.9 support, they dropped 3.6 support. This makes it difficult to test against.

This PR will merge into the enh/h5py3 branch to drop python 3.6 support and add python 3.9 support.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #620 (3188154) into enh/h5py3 (b55bd7c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           enh/h5py3     #620   +/-   ##
==========================================
  Coverage      86.09%   86.09%           
==========================================
  Files             41       41           
  Lines           8268     8268           
  Branches        1780     1780           
==========================================
  Hits            7118     7118           
  Misses           814      814           
  Partials         336      336           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55bd7c...3188154. Read the comment docs.

@rly rly requested a review from a team May 26, 2021 06:53
@rly
Copy link
Contributor Author

rly commented May 26, 2021

The pynwb-dev-python39 test fails because Python 3.9 is not yet supported by PyNWB (but would be after this PR and a corresponding one in PyNWB).

@rly
Copy link
Contributor Author

rly commented May 26, 2021

I could not find an early release of ruamel.yaml in the 0.15.* range that worked for Python 3.7 and all OS's, for use as a minimum version requirement for ruamel.yaml, so I bumped up the minimum requirement to 0.16. If there is a need, we can explore what versions in the 0.15.* range would work.

@rly rly merged commit 655b3d1 into enh/h5py3 May 26, 2021
@rly rly deleted the drop_py36 branch May 26, 2021 17:50
ajtritt added a commit that referenced this pull request Jun 7, 2021
* update h5tools to write with h5py 3

* update requirements

* Enh/h5py3 (#519)

Co-authored-by: Ryan Ly <rly@lbl.gov>
Co-authored-by: Ben Dichter <ben.dichter@gmail.com>
Co-authored-by: Darin Erat Sleiter <darin@ae.studio>

* adapt to write strings as attributes

* allow above h5py 2.9

* allow comparing bytes and str

* add improved h5py.Dataset wrapper class.

* update tests to catch new error statements

* fix flake8 error

* only wrap if in h5py3

* import h5py

* fix flake8

* add representation for StrDataset

* add test for StrDatset

* Update setup.py

* Fix tests

* Drop python 3.6 support, add python 3.9 support (#620)

* check special cases for more than one dimension, too

Co-authored-by: Ryan Ly <rly@lbl.gov>
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-authored-by: Ben Dichter <ben.dichter@gmail.com>
Co-authored-by: Darin Erat Sleiter <darin@ae.studio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants