-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.6 support, add python 3.9 support #620
Conversation
Codecov Report
@@ Coverage Diff @@
## enh/h5py3 #620 +/- ##
==========================================
Coverage 86.09% 86.09%
==========================================
Files 41 41
Lines 8268 8268
Branches 1780 1780
==========================================
Hits 7118 7118
Misses 814 814
Partials 336 336 Continue to review full report at Codecov.
|
The pynwb-dev-python39 test fails because Python 3.9 is not yet supported by PyNWB (but would be after this PR and a corresponding one in PyNWB). |
I could not find an early release of ruamel.yaml in the 0.15.* range that worked for Python 3.7 and all OS's, for use as a minimum version requirement for ruamel.yaml, so I bumped up the minimum requirement to 0.16. If there is a need, we can explore what versions in the 0.15.* range would work. |
* update h5tools to write with h5py 3 * update requirements * Enh/h5py3 (#519) Co-authored-by: Ryan Ly <rly@lbl.gov> Co-authored-by: Ben Dichter <ben.dichter@gmail.com> Co-authored-by: Darin Erat Sleiter <darin@ae.studio> * adapt to write strings as attributes * allow above h5py 2.9 * allow comparing bytes and str * add improved h5py.Dataset wrapper class. * update tests to catch new error statements * fix flake8 error * only wrap if in h5py3 * import h5py * fix flake8 * add representation for StrDataset * add test for StrDatset * Update setup.py * Fix tests * Drop python 3.6 support, add python 3.9 support (#620) * check special cases for more than one dimension, too Co-authored-by: Ryan Ly <rly@lbl.gov> Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com> Co-authored-by: Ben Dichter <ben.dichter@gmail.com> Co-authored-by: Darin Erat Sleiter <darin@ae.studio>
Motivation
Python 3.6 end of life is 23 Dec 2021. The latest versions of h5py, numpy, pandas, scipy do not provide wheels for python 3.6. It seems that generally, if a package added 3.9 support, they dropped 3.6 support. This makes it difficult to test against.
This PR will merge into the
enh/h5py3
branch to drop python 3.6 support and add python 3.9 support.Checklist
flake8
from the source directory.