Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect dtype precision upgrade for VectorIndex #631

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 16, 2021

Motivation

Fix #630.

This is a critical bugfix, so I will release HDMF 2.5.8 after this PR is merged.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #631 (f6d21d2) into dev (36db0e8) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #631      +/-   ##
==========================================
+ Coverage   86.13%   86.19%   +0.06%     
==========================================
  Files          41       41              
  Lines        8238     8239       +1     
  Branches     1776     1777       +1     
==========================================
+ Hits         7096     7102       +6     
+ Misses        811      807       -4     
+ Partials      331      330       -1     
Impacted Files Coverage Δ
src/hdmf/common/table.py 84.13% <100.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36db0e8...f6d21d2. Read the comment docs.

@rly rly requested a review from a team June 16, 2021 20:42
@rly rly merged commit 929ec93 into dev Jun 16, 2021
@rly rly deleted the fix/index_precision branch June 16, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First VectorIndex element for VectorData with >65535 values is incorrect
2 participants