-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _in_construct_mode to differentiate container init vs construct #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #751 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 44 44
Lines 8834 8836 +2
Branches 2033 2033
=======================================
+ Hits 7736 7738 +2
Misses 784 784
Partials 314 314
Help us with your feedback. Take ten seconds to tell us how you rate us. |
oruebel
reviewed
Aug 4, 2022
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
oruebel
reviewed
Aug 4, 2022
oruebel
reviewed
Aug 4, 2022
oruebel
reviewed
Aug 4, 2022
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
oruebel
reviewed
Aug 4, 2022
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
oruebel
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #750. This PR adds a new single-underscore-protected field in
AbstractContainer
called_in_construct_mode
that is set to True if the object is being created by the ObjectMapper when constructing the object from builders read from a file and then reset to False after the object is done being created. Users creating the object will not interact with this field.Subclasses of AbstractContainer can check
_in_construct_mode
to determine whether to raise a warning or error when encountering invalid data (we want to be able to read and fix data that is invalid but not create new data that is invalid).Checklist
flake8
from the source directory.