Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rm/packaging dependency #770

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Rm/packaging dependency #770

merged 5 commits into from
Sep 19, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Sep 19, 2022

Motivation

Fix #767 Implement discussion from #768

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from rly September 19, 2022 16:34
@oruebel oruebel mentioned this pull request Sep 19, 2022
6 tasks
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 87.64% // Head: 87.64% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (780b7c3) compared to base (2010de6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #770      +/-   ##
==========================================
- Coverage   87.64%   87.64%   -0.01%     
==========================================
  Files          44       44              
  Lines        8840     8837       -3     
  Branches     2035     2035              
==========================================
- Hits         7748     7745       -3     
  Misses        777      777              
  Partials      315      315              
Impacted Files Coverage Δ
src/hdmf/common/alignedtable.py 97.66% <100.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rly
Copy link
Contributor

rly commented Sep 19, 2022

@oruebel tests are failing for pandas 1.5.0 (released today). I cannot tell what's wrong. Could you investigate?

@rly
Copy link
Contributor

rly commented Sep 19, 2022

Also, we can remove # pragma: no cover now

@oruebel
Copy link
Contributor Author

oruebel commented Sep 19, 2022

Looking at docs, it looks like Pandas must have reversed the deprecation of inplace so we should be able to just remove the whole version checking and leave as is. I'll test it now.

https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.set_index.html

@oruebel
Copy link
Contributor Author

oruebel commented Sep 19, 2022

it looks like Pandas must have reversed the deprecation

Here the PR where this change to the Pandas API has been reversed pandas-dev/pandas#48417

@rly rly merged commit 707e467 into dev Sep 19, 2022
@rly rly deleted the rm/packaging_dependency branch September 19, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No module named "packaging" when importing hdmf.common
2 participants