Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve links to DynamicTable API docs #939

Merged
merged 11 commits into from
Aug 15, 2023
Merged

improve links to DynamicTable API docs #939

merged 11 commits into from
Aug 15, 2023

Conversation

bendichter
Copy link
Contributor

No description provided.

@bendichter bendichter requested a review from rly August 14, 2023 04:26
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d346736) 88.40% compared to head (eceee67) 88.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #939   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files          45       45           
  Lines        9355     9355           
  Branches     2663     2663           
=======================================
  Hits         8270     8270           
  Misses        766      766           
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bendichter
Copy link
Contributor Author

@mavaylon1 can you please review this when you get a chance?

# To create a :py:class:`~hdmf.common.table.DynamicTable`, call the constructor for
# :py:class:`~hdmf.common.table.DynamicTable` with a string ``name`` and string
# ``description``.
sphinx_gallery_thumbnail_path = 'figures/gallery_thumbnail_dynamictable.png'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sphinx quirk -- this needs to be in its own # comment at the beginning of the script.

rly
rly previously approved these changes Aug 15, 2023
@bendichter bendichter requested a review from rly August 15, 2023 19:08
@bendichter
Copy link
Contributor Author

lgtm, can one of you approve?

@rly rly merged commit f66c1aa into dev Aug 15, 2023
25 of 26 checks passed
@rly rly deleted the docs-dyn-tab-links branch August 15, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants