Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizando o desafio #422

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Finalizando o desafio #422

merged 2 commits into from
Oct 10, 2023

Conversation

pinheir0g
Copy link
Contributor

10 Challenge

Explique um pouco como resolveu o desafio

Pontos interessantes

Observações

lanjoni
lanjoni previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@lanjoni lanjoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigado pela resolução! Apenas um ponto: quando o input é 1000 a resposta deveria ser -1, porém, retornou 1000!
image

@pinheir0g pinheir0g requested a review from lanjoni October 10, 2023 13:23
@k8adev
Copy link
Member

k8adev commented Oct 10, 2023

@pinheir0g rodou perfeito com seu último ajuste! 👏🏻

@k8adev k8adev dismissed lanjoni’s stale review October 10, 2023 15:37

Foi corrigido.

@k8adev k8adev merged commit 16917a8 into he4rt:main Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8adev k8adev k8adev approved these changes

@lanjoni lanjoni Awaiting requested review from lanjoni

Assignees
No one assigned
Labels
Challenge 10 Necessita de correção PR que precisa ser corrigida python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinheir0g @k8adev @lanjoni