feature(dockerimage): better docker image #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Support for mutilple ubuntu versions (22.04, 24.04) 2. Foundations for Release builds to be provided from GitHub release cassandra.so will be provided in GitHub Releases having ubuntu 22.04 (possibly 20.04) we can have better compatiblity with systems (and libraries -> mainly glibc) that are running in production without users having to download the source and build for every patch release 3. fix install path inside docker image -> CIScylla and CICassandra Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
|
Should I review after the tests passes or can do it rn? |
Tests will not pass until new images are built, and that is happening on v1.3.x branch |
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
1 task
CodeLieutenant
added
enhancement
|
Waiting for |
1. Using lowest required php version (8.1) to install composer deps 2. fixing issue with installing cassandra.ini into php.ini in docker image 3. adding a missing new line in php.ini Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for mutilple ubuntu versions (22.04, 24.04)
Foundations for Release builds to be provided from GitHub release cassandra.so will be provided in GitHub Releases having ubuntu 22.04 (possibly 20.04) we can have better compatiblity with systems (and libraries -> mainly glibc) that are running in production without users having to download the source and build for every patch release
fix install path inside docker image -> CIScylla and CICassandra