Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(dockerimage): better docker image #102

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

CodeLieutenant
Copy link
Member

  1. Support for mutilple ubuntu versions (22.04, 24.04)

  2. Foundations for Release builds to be provided from GitHub release cassandra.so will be provided in GitHub Releases having ubuntu 22.04 (possibly 20.04) we can have better compatiblity with systems (and libraries -> mainly glibc) that are running in production without users having to download the source and build for every patch release

  3. fix install path inside docker image -> CIScylla and CICassandra

1. Support for mutilple ubuntu versions (22.04, 24.04)
2. Foundations for Release builds to be provided from GitHub release
   cassandra.so will be provided in GitHub Releases
   having ubuntu 22.04 (possibly 20.04) we can have better compatiblity
   with systems (and libraries -> mainly glibc) that are running in
   production without users having to download the source and build for
   every patch release
3. fix install path inside docker image -> CIScylla and CICassandra

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@DanielHe4rt
Copy link
Collaborator

Should I review after the tests passes or can do it rn?

@CodeLieutenant
Copy link
Member Author

Should I review after the tests passes or can do it rn?

Tests will not pass until new images are built, and that is happening on v1.3.x branch

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@CodeLieutenant CodeLieutenant added enhancement New feature or request good first issue Good for newcomers labels Aug 11, 2024
@CodeLieutenant
Copy link
Member Author

CodeLieutenant commented Aug 11, 2024

Waiting for Build Docker Images for Testing

1. Using lowest required php version (8.1) to install composer deps
2. fixing issue with installing cassandra.ini into php.ini in docker
   image
3. adding a missing new line in php.ini

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@CodeLieutenant CodeLieutenant merged commit 871d2ed into v1.3.x Aug 12, 2024
1 of 25 checks passed
@CodeLieutenant CodeLieutenant deleted the feat/better-docker-image branch August 12, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: In Verification
Development

Successfully merging this pull request may close these issues.

2 participants