github: Switch azure login to OIDC connect #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github issues every job a token, and a service principal in Azure can be configured to trust that token. This is called "federated credentials" or OpenID Connect. Switch to using the azure/login action and enable write access on the id-token for the jobs that need it. Preserve the default `contents: read` permission and move the tenant id to a secret. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
The build container failure is unrelated to this PR and is fixed in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @jepio:
Github issues every job a token, and a service principal in Azure can be configured to trust that token. This is called "federated credentials" or OpenID Connect. Switch to using the azure/login action and enable write access on the id-token for the jobs that need it.
Preserve the default
contents: readpermission and move the tenant id to a secret.