frontend: Accept given YAML/JSON in EditorDialog #1982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoeva
changed the title
skoeva
force-pushed
the
editordialog-changes
branch
2 times, most recently
from
5469dab
to
8ebede7
Compare
This change aims to allow EditorDialog to accept generic YAML/JSON text rather than explicitly expecting an item that looks like a Kubernetes resource. It also adds placeholder text in the editor for improving accessibility. Fixes: #1820 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
force-pushed
the
editordialog-changes
branch
from
7688c0c
to
df048cd
Compare
|
Closed in favor of #1996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to allow
EditorDialogto accept generic YAML/JSON text rather than explicitly expecting an item that looks like a Kubernetes resource. It also adds placeholder text in the editor for improving accessibility.Fixes: #1820