Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headlamp-plugin: Install tar and update dependencies-sync #2325

Merged
merged 1 commit into from
Sep 13, 2024
Merged

headlamp-plugin: Install tar and update dependencies-sync #2325

merged 1 commit into from
Sep 13, 2024

Conversation

skoeva
Copy link
Contributor

@skoeva skoeva commented Sep 11, 2024 •
edited
Loading

This change addresses the plugins test failure in the CI.

Fixes: #2324

Testing

Tested on issue #1996 in this commit.

  • Run make plugins-test and ensure that it passes

@skoeva skoeva added the regression Bugs for things that used to work in previous releases. label Sep 11, 2024
@skoeva skoeva requested a review from illume September 11, 2024 18:41
@skoeva skoeva self-assigned this Sep 11, 2024
@skoeva skoeva linked an issue Sep 11, 2024 that may be closed by this pull request
make plugins-test in CI fails #2324
Closed
@skoeva skoeva added bug Something isn't working and removed regression Bugs for things that used to work in previous releases. labels Sep 11, 2024
@vyncent-t
Copy link
Contributor

vyncent-t commented Sep 11, 2024 •
edited
Loading

it would be good to detail out the reproduction steps, I'm assuming its meant to be ran at the root level of the project.

I also seem to be hitting a different error than the one you have in the original issue

image

@vyncent-t
Copy link
Contributor

also, I would try

  • pull from main for the most recent changes
  • remove the node modules folders in the frontend and plugins
  • run npm i for frontend and then npm i for the plugins
  • run make plugins-test again

sniok
sniok requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix, thanks! just remove tar from frontend and we can merge this

frontend/package.json Outdated Show resolved Hide resolved
@skoeva
headlamp-plugin: Install tar and update dependencies-sync
23dcdd5 
This change addresses the plugins test failure in the CI.

Fixes: #2324

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva skoeva changed the title frontend: Install tar and sync to headlamp-plugin headlamp-plugin: Install tar and update dependencies-sync Sep 12, 2024
illume
illume approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume merged commit 3700066 into main Sep 13, 2024
13 checks passed
@illume illume deleted the fix-test-plugins-failure branch September 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniok sniok sniok approved these changes

@illume illume illume approved these changes

Assignees

@skoeva skoeva

Labels
bug Something isn't working
Projects
Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make plugins-test in CI fails
4 participants
@skoeva @vyncent-t @illume @sniok