backend: refactor listing all contexts and error #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Code coverage changed from 60.1% to 61.6%. Change: 1.5% 😃. |
yolossn
reviewed
Sep 12, 2024
yolossn
reviewed
Sep 12, 2024
yolossn
reviewed
Sep 12, 2024
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
9a586c6
to
0ee9a5a
Compare
|
Backend Code coverage changed from 60.1% to 61.6%. Change: 1.5% 😃. |
yolossn
reviewed
Sep 17, 2024
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
0ee9a5a
to
f39dbd8
Compare
|
Backend Code coverage changed from 60.1% to 61.9%. Change: 1.8% 😃. |
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
f39dbd8
to
8daa9d0
Compare
|
Backend Code coverage changed from 60.1% to 61.7%. Change: 1.6% 😃. |
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
8daa9d0
to
119a645
Compare
|
Backend Code coverage changed from 60.2% to 61.7%. Change: 1.5% 😃. |
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
119a645
to
a07ce59
Compare
|
Backend Code coverage changed from 60.2% to 61.6%. Change: 1.4% 😃. |
illume
reviewed
Sep 24, 2024
illume
reviewed
Sep 24, 2024
illume
reviewed
Sep 24, 2024
illume
reviewed
Sep 24, 2024
illume
reviewed
Sep 24, 2024
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
a07ce59
to
a404b72
Compare
|
Backend Code coverage changed from 60.2% to 61.6%. Change: 1.4% 😃. |
knrt10
changed the title
illume
reviewed
Sep 25, 2024
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
a404b72
to
5d0ceee
Compare
dosubot
bot
added
the
size:XXL
|
Backend Code coverage changed from 60.1% to 61.8%. Change: 1.7% 😃. Coverage report |
illume
reviewed
Sep 27, 2024
illume
reviewed
Sep 27, 2024
|
I think we can merge this because it fixes some issues, and generally improves things. However, in the future I think we need to look into using context Name or not. It's not really unique or even required to be there strictly (however for 99% of users it probably is there). We need something which is unique across clusters, and is stable after a restart. Currently much of the frontend assumes this value is non-empty and unique - which isn't true strictly. Leaving my comments here for future work...I'm not sure about using "" here. Why was that chosen over an empty string "" or nil? kubectl just gives nothing if a context doesn't have a name. kubectl can work without a name, because it uses the current context. I also wonder about the uniqueness of the name if there are multiple ones with out a name? Ultimately we'd want to ask the user if they can set a name? Additionally, what about using the other two fields? User name and cluster name? Maybe we can also handle this case outside of this PR. The errors and context could be returned as a parallel array, so that at least in our code the error can be matched up with the context no matter the name. |
illume
reviewed
Sep 27, 2024
This removes the dependacy of manually parsing of k8s resources. It was a problem as we had to be in sync with k8s API changes, which is not a good way. This change removes that and it splits kubeconfig into seperate contexts and validates them. Fixes: #2347 Co-Authored-By: Santhosh Nagaraj <sannagaraj@microsoft.com> Signed-off-by: Kautilya Tripathi <ktripathi@microsoft.com>
knrt10
force-pushed
the
kubeconfig-refactor
branch
from
5d0ceee
to
f01f0f6
Compare
|
Backend Code coverage changed from 60.1% to 61.8%. Change: 1.7% 😃. Coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependacy of manually parsing of k8s resources. It was a problem as we had to be in sync with k8s API changes, which is not a good way. This change removes that and it splits kubeconfig into seperate contexts and validates them.
Testing
cd backend && go run ./cmd -devcd frontend && npm startReference
#2289 (comment)