frontend: headlamp-plugin: Update dependencies #2361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
illume
commented
Sep 30, 2024
illume
commented
- Update reduxtoolkit, and remove redux-mock-store and types to reduce third party deps.
illume
force-pushed
the
front-deps
branch
8 times, most recently
from
86183f3
to
e6e6423
Compare
This can be seen when building the headlamp-plugin tar.gz Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Otherwise an old typescript is installed. This is a work around. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
…ncies This is so that @headlamp-k8s/eslint-config is installed to top level of node_modules/@headlamp-k8s/eslint-config Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
This seems to fix an error with react-router-dom and MemoryRouter. I think this makes sense, because if there are @types/ then those should be considered first, because you only use @types/ packages for when the main package does not have any types. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Remove redux-mock-store and types to reduce third party deps. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.