Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: RoleList: Make multi cluster aware #2437

Merged
merged 2 commits into from
Oct 30, 2024
Merged

frontend: RoleList: Make multi cluster aware #2437

merged 2 commits into from
Oct 30, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Oct 16, 2024 •
edited
Loading

In single cluster mode the RoleList is the same.

The ColumnType is exported needed here to keep the typechecker happy.

How to test

@illume illume changed the title frontend: RoleList: Make multi cluster aware WIP: frontend: RoleList: Make multi cluster aware Oct 16, 2024
@illume illume added frontend Issues related to the frontend multi Multi cluster aggregated view labels Oct 16, 2024
@illume illume mentioned this pull request Oct 17, 2024
Open
24 tasks
@illume illume changed the title WIP: frontend: RoleList: Make multi cluster aware frontend: RoleList: Make multi cluster aware Oct 29, 2024
@illume illume marked this pull request as ready for review October 29, 2024 12:30
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 29, 2024
joaquimrocha
joaquimrocha approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ResourceTable change could be a different commit.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@illume
frontend: ResourceTable: Export ColumnType
43c04bc 
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
frontend: RoleList: Make multi cluster aware
57d5722 
In single cluster mode the RoleList is the same.

Signed-off-by: René Dudfield <renedudfield@microsoft.com>
@illume
Copy link
Collaborator Author

illume commented Oct 30, 2024

(Rebased against main, and moved the ResourceTable change into a separate commit.)

@illume illume merged commit 8ff7f60 into main Oct 30, 2024
18 checks passed
@illume illume deleted the role-list-multi branch October 30, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquimrocha joaquimrocha joaquimrocha approved these changes

Assignees
No one assigned
Labels
frontend Issues related to the frontend lgtm This PR has been approved by a maintainer multi Multi cluster aggregated view size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illume @joaquimrocha