frontend: Improve scroll bars #2715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoeva
force-pushed
the
scrollbar-fix
branch
from
e106dbf to
cda138e
Compare
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
force-pushed
the
scrollbar-fix
branch
2 times, most recently
from
87d25ca to
3e3b634
Compare
dosubot
bot
added
the
size:M
sniok
reviewed
Dec 23, 2024
| flexGrow: 1, | ||
| marginLeft: 'initial', | ||
| overflow: 'auto', | ||
| [theme.breakpoints.down('sm')]: { marginTop: { xs: '-12px', sm: '-8px' } }, |
There was a problem hiding this comment.
that's a lot of new magic values (64px, 72px, -12px, -8px). maybe we can do this change without introducing them? maybe making topbar not positioned absolute or sticky.
or if that's not possible at least introduce some constants and plan for a possibility that topbar size might be changed in the future
There was a problem hiding this comment.
if the topbar isn't set to fixed then that defeats the purpose of it right? I think the new values are a good workaround (temporary if we can fix the topbar somehow) so I can abstract them into constants for now
sniok
reviewed
Dec 23, 2024
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva
force-pushed
the
scrollbar-fix
branch
from
3e3b634 to
8e9c095
Compare
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes display the scroll bars for the main content and sidebar under the top bar. The width of the sidebar and the height of the top bar are also adjusted to prevent inconsistencies.
Fixes: #2679
Testing