-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): refactor readme #37
Conversation
631ef47
to
9eede25
Compare
@ChipWolf Ok one second: this was done by release-please automatically, so there's a problem with that. |
Oh hah it's the release-please comments in the markdown file. Instead of using the block comments we could just use the inline one like in action.yml, but because it's in a code block it'll unfortunately be visible to the end user. I used the block comments to avoid ambiguity, but alas |
I see, same issue as this: googleapis/release-please#2345 We could define the code block with html like this <!-- x-release-please-start-version -->
<pre>
<code class="language-yml">
... yaml stuff But the yaml syntax highlighting wont work. I think I will just update the version string manually within the README now? |
I think I will try a workflow that runs after release-please and fixes the readme |
sed -i -E 's/^(\s+)mc: .+$/\1mc: 1.21.4/' README.md
|
@3arthqu4ke I've put a good amount of thought into this In theory, we should only have the major version referenced in the README, i.e. To achieve this we're going to have to do some trickery in the release pipeline, I'll be setting up a PR for this soon We should also assess which tags are in use and push deprecated notices to them all. |
For now, that last commit should do the trick @3arthqu4ke |
0d8d04a
to
96820d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit c91b5c8.
e102df7
to
c1e2cca
Compare
Release-please seems to update all version strings within a markdown code block.