fix(appium-tizen-tv-driver,tizen-remote): do not always force token #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the only time when we should specifically force a new token is when `appium:resetRcToken` is `true`. also, immediately after instantiation, unless a token has been provided to `TizenRemote` (or via the env), the `hasToken()` method may resolve `true`, but it will not actually _set_ the token in memory from the cache due to it being a naughty side-effect. unless `getToken()` was explicitly called, the token would not be set in-memory from the cache before the connection attempt. the logic has changed so that, at connection time, we attempt to load the token from cache if one exists (and cache persistence is enabled). if one still doesn't exist after connection, then it will ask for a new one. also fixes some typescript problems which may actually be a bug in typescript. microsoft/TypeScript#50286 adds a (slow) e2e test suite for checking persistence works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only time when we should specifically force a new token is when
appium:resetRcTokenistrue.also, immediately after instantiation, unless a token has been provided to
TizenRemote(or via the env), thehasToken()method may resolvetrue, but it will not actually set the token in memory from the cache due to it being a naughty side-effect. unlessgetToken()was explicitly called, the token would not be set in-memory from the cache before the connection attempt. the logic has changed so that, at connection time, we attempt to load the token from cache if one exists (and cache persistence is enabled). if one still doesn't exist after connection, then it will ask for a new one.also fixes some typescript problems which may actually be a bug in typescript. microsoft/TypeScript#50286
adds a (slow) e2e test suite for checking persistence works