Skip to content

Definition of Done

Felix Pütz edited this page Jan 19, 2021 · 4 revisions

For every change that comes into the codebase we'd like the following conditions met:

  1. A pull request is created,
  2. It's assigned to the creator/reporter,
  3. The PR gets at least 2 approvals,
    • Reviewers should have done the following
      • Code Review
      • Functional testing
      • Another functional test of the base-branch after merging it into it
  4. Both the functionality and the code get a glimpse from reviewers,
  5. The assignee can then merge the PR,
  6. The merger makes sure that the merge target branch still works.
Clone this wiki locally