-
Notifications
You must be signed in to change notification settings - Fork 31
Definition of Done
Felix Pütz edited this page Jan 19, 2021
·
4 revisions
For every change that comes into the codebase we'd like the following conditions met:
- A pull request is created,
- It's assigned to the creator/reporter,
- The PR gets at least 2 approvals,
- Reviewers should have done the following
- Code Review
- Functional testing
- Another functional test of the base-branch after merging it into it
- Reviewers should have done the following
- Both the functionality and the code get a glimpse from reviewers,
- The assignee can then merge the PR,
- The merger makes sure that the merge target branch still works.