-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding lsf-platform to compute envs #57
Conversation
Sorry, couldn't find the test suite, will add. |
No problem! The repo it's not great documented for external contributors, something to work on😄 |
Hi @timini you need to run locally Thanks! |
@alexhermida can you kick off the tests again please? |
hi @alexhermida I'm interested in adding secrets support as a separate MR (sorry couldn't find a way to open an issue for discussion). How would i go about testing it locally, does it have to be done against a live instance of tower? |
What do you mean adding secrets support? As it's right now already requires If it's ok. I'll merge this and feel free to open a new MR with the code, we can discuss there if it's appropiate, probably is easier with the code 😄 Thanks! |
This PR adds support for IBM LSF compute envs