Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored devise mailer functionality into a module. #1164

Closed
wants to merge 1 commit into from
Closed

Refactored devise mailer functionality into a module. #1164

wants to merge 1 commit into from

Conversation

fosrias
Copy link

@fosrias fosrias commented Jun 23, 2011

Let me know if you have any questions. I added a usage example in the module documentation in /lib/devise/mailers.rb.

Enables easily extending third party mailers as devise mailers.
@josevalim
Copy link
Contributor

Thanks for the pull request but I believe those names are a bit confusing: Devise::Mailers and Devise::Mailer.

@railsamf
Copy link

Given that Devise::Mailer is a class, I chose Devise::Mailers as it was related and made sense in terms of a library. Happy to change the module name, but I suspect you would have a better opinion on the convention for the module name. If you would choose a module name you think is appropriate, I will make the changes and resubmit the pull request. Thanks.

@fosrias
Copy link
Author

fosrias commented Jun 23, 2011

Sorry, logged in with wrong account. railsamf is another github account I (fosrias) have.

@josevalim josevalim closed this in 42f0285 Jun 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants