Issue #4941 , handle error 'Please specify the Rails release the migr… #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the migration was written for'
| def rails5? | ||
| Rails.version.start_with? '5' | ||
| def rails5_and_up? | ||
| Rails::VERSION::MAJOR >= 5 |
There was a problem hiding this comment.
This constant is private. Maybe Rails.gem_version >= Gem::Version('5.0.0')?
There was a problem hiding this comment.
Ah, it is public, so this is fine.
|
Can you also test devise with Rails 6. Right now it is not tested so I don't want to recommend people to use it. |
|
My new app worked ok I guess, basic tests passed and running on heroku at https://untitled-d68f47d.herokuapp.com/ The only caveat was the responders gem still didn't "recognize" rails 6 - I sent a PR |
tegon
approved these changes
Sep 28, 2018
|
This is great. Any chance we'll see it in a release soon? |
|
@jcoyne Yep, there are still some issues to solve with Rails 6, so when we manage to do it a new version is going to be released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4941 , handle error 'Please specify the Rails release the migration was written for'