Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5505 - trigger setter instead of setting local var #5506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

5505 - trigger setter instead of setting local var #5506

wants to merge 1 commit into from

Conversation

yasirazgar
Copy link

@yasirazgar yasirazgar commented Jul 3, 2022 •
edited
Loading

Fixes: #5505

Changed resource = warden.user(resource_name) to self.resource = warden.user(resource_name) in devise_controller#require_no_authentication so that setter resource = is triggered and instance variable @user is populated.

@yasirazgar
5505 - trigger setter instead of setting local var
5800841 
use self.resource in devise_controller#require_no_authentication so that the setter is triggered, and instance variable @user is populated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local variable used instead of calling the setter in devise_controller#require_no_authentication
1 participant
@yasirazgar