Skip valid_class check if no class defined #1656
Labels
Comments
TALlama
added a commit
to TALlama/simple_form
that referenced
this issue
Apr 23, 2019
heartcombo#1656 Previously, we would check for validity all the time, even if the outcome of the check added no class. This meant that there was no way to opt out of the check in cases where it was expensive (if the file is stored in S3, in our example). Now, we only check for validity if there is a valid_class defined to be added if the field is valid.
|
@TALlama I think this issue can be closed, right? |
|
Oh yeah, it seems closed. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Current behavior
We have a simple file input in our form:
As of 4.1, this is now a performance problem, because the file in question is stored in S3, and each time we render this form we now fetch the file from S3 to check if it's present, because
simple_formwants to add thevalid_class. In our case this is one of several such forms on the same page, which is now prohibitively slow.We have defined
valid_class: nilin our wrapper config, butsimple_formstill does the work to determine validity even if no class will be added if we are valid. We also marked the field asrequired: falsein hopes that it being optional would allow it to be valid when it's not present, but that doesn't affect anything either.This is very similar to #1596, except that only talks about getting rid of the CSS class, whereas I want to go a step further and avoid doing the (sometimes expensive) work that determines if a CSS class is necessary.
Expected behavior
If
valid_classisnil(in the wrapper config or in the input options), no validity check should be performed.The text was updated successfully, but these errors were encountered: