Shorten polling intervals for test playback

Fixes Azure#14557
heaths · Sep 1, 2020 · 2cb864e · 2cb864e
1 parent fba9094
commit 2cb864e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/sdk/keyvault/Azure.Security.KeyVault.Keys/tests/KeyClientLiveTests.cs b/sdk/keyvault/Azure.Security.KeyVault.Keys/tests/KeyClientLiveTests.cs
@@ -586,7 +586,7 @@ public async Task DeleteEcHsmKey()
 
             DeleteKeyOperation operation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await operation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await operation.WaitForCompletionAsync(PollingInterval, default);
 
             Assert.NotNull(deletedKey.DeletedOn);
             Assert.NotNull(deletedKey.RecoveryId);
@@ -608,7 +608,7 @@ public async Task DeleteRsaHsmKey()
 
             DeleteKeyOperation operation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await operation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await operation.WaitForCompletionAsync(PollingInterval, default);
 
             Assert.NotNull(deletedKey.DeletedOn);
             Assert.NotNull(deletedKey.RecoveryId);
@@ -660,7 +660,7 @@ public async Task GetDeletedEcHsmKey()
 
             DeleteKeyOperation operation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await operation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await operation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForDeletedKey(keyName);
 
@@ -686,7 +686,7 @@ public async Task GetDeletedRsaHsmKey()
 
             DeleteKeyOperation operation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await operation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await operation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForDeletedKey(keyName);
 
@@ -745,15 +745,15 @@ public async Task RecoverDeletedEcHsmKey()
 
             DeleteKeyOperation deleteOperation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await deleteOperation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await deleteOperation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForDeletedKey(keyName);
 
             Assert.ThrowsAsync<RequestFailedException>(() => Client.GetKeyAsync(keyName));
 
             RecoverDeletedKeyOperation recoverOperation = await Client.StartRecoverDeletedKeyAsync(keyName);
 
-            KeyVaultKey recoverKeyResult = await recoverOperation.WaitForCompletionAsync();
+            KeyVaultKey recoverKeyResult = await recoverOperation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForKey(keyName);
 
@@ -777,15 +777,15 @@ public async Task RecoverDeletedRsaHsmKey()
 
             DeleteKeyOperation deleteOperation = await Client.StartDeleteKeyAsync(keyName);
 
-            DeletedKey deletedKey = await deleteOperation.WaitForCompletionAsync();
+            DeletedKey deletedKey = await deleteOperation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForDeletedKey(keyName);
 
             Assert.ThrowsAsync<RequestFailedException>(() => Client.GetKeyAsync(keyName));
 
             RecoverDeletedKeyOperation recoverOperation = await Client.StartRecoverDeletedKeyAsync(keyName);
 
-            KeyVaultKey recoverKeyResult = await recoverOperation.WaitForCompletionAsync();
+            KeyVaultKey recoverKeyResult = await recoverOperation.WaitForCompletionAsync(PollingInterval, default);
 
             await WaitForKey(keyName);
 

diff --git a/sdk/keyvault/Azure.Security.KeyVault.Keys/tests/KeysTestBase.cs b/sdk/keyvault/Azure.Security.KeyVault.Keys/tests/KeysTestBase.cs
@@ -21,7 +21,9 @@ public abstract class KeysTestBase : RecordedTestBase<KeyVaultTestEnvironment>
     {
         public const string AzureKeyVaultUrlEnvironmentVariable = "AZURE_KEYVAULT_URL";
 
-        protected readonly TimeSpan PollingInterval = TimeSpan.FromSeconds(5);
+        protected TimeSpan PollingInterval => Recording.Mode == RecordedTestMode.Playback
+            ? TimeSpan.Zero
+            : TimeSpan.FromSeconds(2);
 
         public KeyClient Client { get; set; }