forked from Azure/azure-sdk-for-net
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define onlyIfUnchanged for ETag support #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.
Based on internal comments, we'll proceed further down this route. |
heaths
added a commit
that referenced
this pull request
Apr 28, 2020
This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.
heaths
added a commit
that referenced
this pull request
Apr 29, 2020
…ions (Azure#11420) * Combine MatchConditions and SearchRequestOptions Fixes Azure#11052 * Redefine ETag properties as Azure.ETag? Fixes Azure#11385 * Update public APIs * Define onlyIfUnchanged for ETag support (#2) This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well. * Update CHANGELOG and public APIs
heaths
pushed a commit
that referenced
this pull request
Jan 4, 2021
* Updated version number * Try #2 on beta.1 * Fixed typo in version number
heaths
pushed a commit
that referenced
this pull request
Aug 27, 2021
heaths
pushed a commit
that referenced
this pull request
Apr 27, 2023
…nd add test coverage (Azure#34743) * generated code using autorest * fix mongo collection functions in Custom/RestorableCosmosDBAccountResource.cs * Fix breaking changes that coming from the safeflatten * InAccount restore changes for all api kinds * resolve build errors and update mongo db inaccount restore tests * update session records * resolve build errors after merge conflicts * regenerated changes using dotnet build /t:GenerateCode * update default values * fix test with default identity * updated with eng\scripts\CodeChecks.ps1 -ServiceDirectory cosmosdb * update sesion records for failing pipeline * update sesion records for failing pipeline * update inaccount restore tests to use static time and session records for table and gremlin tests * Update recording * Update recording * update session records for sql and mongo and disable mongo inaccount restore tests * update generated files with latest * updated test case for burst capacity * update session records for database account operations * updated test case to not enable burst capacity in account creation (#2) * recorded all tests in DatabaseAccount (#3) * updated test case to not enable burst capacity in account creation * recorded all tests in DatabaseAccount * session recordings of DatabaseAccountTests * cross region restore updated test * test recordings update * updated recordings * added new group cross region restore * udpated recordings with playback verification * updated RestorabledatabaseAccountTests groupo * update session records for private end point tests * Rename BackupResource to CassandraClusterBackupResource * Update API * update changelog for new sdk release --------- Co-authored-by: Arthur Ma <arthurma@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> Co-authored-by: Richa Sharma <richasharma@microsoft.com> Co-authored-by: Richa Sharma <richasharma.amu@gmail.com> Co-authored-by: dsapaliga <dsapaliga@microsoft.com>
heaths
pushed a commit
that referenced
this pull request
Jul 6, 2023
…leSnippets.cs. (Azure#37422) * Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source. * Fixing missing double quote on region identifier. * Updating sample C# snippets and code (#2) * Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> Co-authored-by: Michal Materna <michal.materna@hotmail.com>
heaths
pushed a commit
that referenced
this pull request
Sep 14, 2023
…re#38386) * Update Readme.md snippets to be populated by tool, added SampleSnippets.cs file as source. * Fixing missing double quote on region identifier. * Updating sample C# snippets and code (#2) * Updating sample C# snippets and code. * Use explicit type instead of var, remove blank lines from #if * Finished change to use explicit type instead of var --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> * Replace async samples with synchronous code * Corrected reference to async samples in README.md --------- Co-authored-by: Rango Meadows <v-rameadows@microsoft.com> Co-authored-by: Michal Materna <michal.materna@hotmail.com>
heaths
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Update autorest.md file with latest swagger and allow model duplication * Generate and upgrade sdk code * Customize redis common configuration code to include aad-enabled * Regenerate API file * Customize redis common configuration code to include aad-enabled * Mitigate breaking change * Create empty test-resources.json * Create FlushFunctionalTests.cs * Update assets.json * Add functional tests for aad (#2) Adds functional tests for aad * Update Channel Tests (#3) * Oscarba/fix (#4) * Update Channel Tests * Update correct data type * Push regenerated code * UpdateChannelFix (#5) * Update Channel Tests * Update correct data type * Update test * Update tag for assets after push for recordings * Address reviewer comments * Update generatred code after mergin in main * Update FTs for updated models * Update AAD FT * Update assets.json * Update changelog --------- Co-authored-by: Kanchan Joshi <kanchanjoshi@microsoft.com> Co-authored-by: Austin Tolani <austintolani@microsoft.com> Co-authored-by: Oscar Barbosa Aquino <32723476+Darfeikus@users.noreply.github.com>
heaths
pushed a commit
that referenced
this pull request
May 7, 2024
* Update Generator Version 3.0.0-beta.20240404.1 * Update SDK codes he_mi_3 * Update SDK codes de_he_2 * Update SDK codes ad_co_0 * Update SDK codes sq_wo_6 * Update SDK codes mi_pu_4 * Update SDK codes pu_sq_5 * Update SDK codes co_de_1 * Build fix * Build fix #2 * Build fix #3 --------- Co-authored-by: Alexander Sher <alsher@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested to match what AppConfiguration does. It simplifies it, with no practical reason for IfNoneMatch. We could always add that later as well.