Remove pass_by_value property

heavyai · Dec 14, 2022 · 34b28f1 · 34b28f1
1 parent ba48cb3
commit 34b28f1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/rbc/heavydb/buffer.py b/rbc/heavydb/buffer.py
@@ -42,12 +42,6 @@
 class HeavyDBBufferType(typesystem.Type):
     """Typesystem type class for HeavyDB buffer structures.
     """
-    # When True, buffer type arguments are passed by value to
-    # functions [not recommended].
-    @property
-    def pass_by_value(self):
-        return False
-
     @property
     def numba_pointer_type(self):
         return BufferPointer
@@ -81,8 +75,6 @@ def tonumba(self, bool_is_int8=None):
         buffer_type._params['NumbaType'] = BufferType
         buffer_type._params['NumbaPointerType'] = self.numba_pointer_type
         numba_type = buffer_type.tonumba(bool_is_int8=True)
-        if self.pass_by_value:
-            return numba_type
         return self.numba_pointer_type(numba_type)
 
 

diff --git a/rbc/heavydb/column.py b/rbc/heavydb/column.py
@@ -24,11 +24,6 @@
 class HeavyDBColumnType(HeavyDBBufferType):
     """Heavydb Column type for RBC typesystem.
     """
-    @property
-    def pass_by_value(self):
-        heavydb_version = TargetInfo().software[1][:3]
-        return heavydb_version <= (5, 7, 0)
-
     def match(self, other):
         if type(self) is type(other):
             return self[0] == other[0]