Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix linter warnings #136

Merged
merged 3 commits into from
Apr 3, 2024
Merged

cmake: Fix linter warnings #136

merged 3 commits into from
Apr 3, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Apr 2, 2024

No description provided.

Fix lint-shell-locale.py linter warning.
@hebasto
Copy link
Owner Author

hebasto commented Apr 2, 2024

Friendly ping @m3dwards @pablomartin4btc @TheCharlatan @vasild :)

Copy link

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr ACK 399e182

Tested linter warning fix on last commit (399e182).
  • Before:
./test/lint/lint-shell-locale.py 
Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in cmake/script/macos_zip.sh

@hebasto hebasto merged commit a3313e2 into cmake-staging Apr 3, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants