-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Drop unused packages from Guix manifest #294
Conversation
adee830
to
44520e4
Compare
44520e4
to
5787fc8
Compare
5787fc8
to
5bd79c8
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5bd79c8
Guix build:
97b53eb6575fcead1e7c5a6cd4328b3f273111565d93a731dd27232e893a0ba5 bitcoin-5bd79c8a3b1d-aarch64-linux-gnu-debug.tar.gz
005be1117d9cda160c6237055673537bc31ec703990911728e9a1db9308bd39c bitcoin-5bd79c8a3b1d-aarch64-linux-gnu.tar.gz
bc253c2b614551f754316fa60a84e18130d25fed712503b68de65ea1e9c5ff01 bitcoin-5bd79c8a3b1d-arm-linux-gnueabihf-debug.tar.gz
36ec70f3c45344e34519ff26498f617af7e49ce6a24c169ae57ad05fa62a5558 bitcoin-5bd79c8a3b1d-arm-linux-gnueabihf.tar.gz
3bb7cd7fd1b8d31226c5cad2d0f5b4b58e75a0875d9e2b81d08dcd3837fd67f8 bitcoin-5bd79c8a3b1d-arm64-apple-darwin-unsigned.tar.gz
e4da873203189a6b0b0c866bda0408a975ee584c49f7fa2b1aca6b82ae5ad3e3 bitcoin-5bd79c8a3b1d-arm64-apple-darwin-unsigned.zip
ba9760a2dece2e77375838b5b55f4dbe9dcf9c01244305447f7272a9667166cf bitcoin-5bd79c8a3b1d-arm64-apple-darwin.tar.gz
abd20cde611c7a694d48ad4d43b96710899e0ca9bb18855f2df7938127c25c32 bitcoin-5bd79c8a3b1d.tar.gz
2fba9b628254922443fb8c42c83884642b6246e3ae2f4f52ef33458d0aae7013 bitcoin-5bd79c8a3b1d-powerpc64-linux-gnu-debug.tar.gz
5c7e3fdd12aff1e31c0ac4d36001997e7be3d38c0caf910ea26dfb6ec848c8d4 bitcoin-5bd79c8a3b1d-powerpc64-linux-gnu.tar.gz
ad3ae05fbb3cf65fe25a3c9900e3af061f46206523f4f5348b63d4bfd09262cc bitcoin-5bd79c8a3b1d-riscv64-linux-gnu-debug.tar.gz
5734943ce2d9c623eb7ac28881518af7f175ef0bff43462033cacb86b5d4797a bitcoin-5bd79c8a3b1d-riscv64-linux-gnu.tar.gz
b30b2d770cd6b17aa0522ed74f2aefb835d75834afac8b430e24bb255bb908cc bitcoin-5bd79c8a3b1d-x86_64-apple-darwin-unsigned.tar.gz
382b075335442b00be51bd6f82f687fe69e0205d140ccc7c64a40e0d562d44ec bitcoin-5bd79c8a3b1d-x86_64-apple-darwin-unsigned.zip
9d8c38d419a0390701e164396663227e1174c7d1c02110c1c493875baf1a6e5f bitcoin-5bd79c8a3b1d-x86_64-apple-darwin.tar.gz
0667ff88b606d7c546860b33c1b05283e94c26de7462d2aedce3370be87d9c55 bitcoin-5bd79c8a3b1d-x86_64-linux-gnu-debug.tar.gz
97b491210a93cd1f56965e348486ef8537f4340a1a3dc3be0e327c4e526ce133 bitcoin-5bd79c8a3b1d-x86_64-linux-gnu.tar.gz
37fa0d5eb76317326caff141e06e9c6cdec6ea6a599748f5d7ed3653e3059231 bitcoin-5bd79c8a3b1d-win64-debug.zip
e8da6957144f6d52e3778bf1fca7949e1271a044de80cf6c2ef89aa9160f78e5 bitcoin-5bd79c8a3b1d-win64-setup-unsigned.exe
55ecfc3f523910a48ed3dc33d56b03254828476f9542dac9d8116033d47c5431 bitcoin-5bd79c8a3b1d-win64-unsigned.tar.gz
ea39931b2cb134113bee325c2adc0ed61a901a0b3fddc89a8a728e03f0251afe bitcoin-5bd79c8a3b1d-win64.zip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK.
I'll defer to @fanquake on this one. Seems we could always add them back if needed, though it'd be nice if things just worked if we ever needed to bootstrap a dep, without having to track down this history.
I'm not too fussed at this point. They may just end up back if we do more from-source builds. |
5bd79c8
to
3b790b0
Compare
Rebased. |
I think this can just be rolled into bitcoin#30664. |
I think guix was already bumped to cmake, so this can be done in a separate pull already today? |
Done in bitcoin#30752. |
0004dcc guix: Drop unused autotools packages (Hennadii Stepanov) Pull request description: This PR implements hebasto#294. From hebasto#294 (comment): > I think guix was already bumped to cmake, so this can be done in a separate pull already today? ACKs for top commit: fanquake: ACK 0004dcc Tree-SHA512: 60d0be8df6340797bebcd6a734e2a5a0a24df18b65c174af47ea652110f26aca00b019dd205b83ae0e664ba1322628f252ade461d2dc01353045347d405ad5fa
Autotools installation is not required at this moment.
Drafted because of thisfeedback:My Guix build: