-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake, doc: Update test/README.md
and other docs
#324
Conversation
cc @maflcko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e16f24e
Left some nits and questions
``` | ||
|
||
You can run any combination (incl. duplicates) of tests by calling: | ||
|
||
``` | ||
test/functional/test_runner.py <testname1> <testname2> <testname3> ... | ||
build/test/functional/test_runner.py <testname1> <testname2> <testname3> ... | ||
``` | ||
|
||
Wildcard test names can be passed, if the paths are coherent and the test runner | ||
is called from a `bash` shell or similar that does the globbing. For example, | ||
to run all the wallet tests: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
```bash
functional/test_runner.py functional/wallet* (called from the test/ directory) | ||
test_runner.py wallet* (called from the test/functional/ directory) | ||
build/test/functional/test_runner.py test/functional/wallet* | ||
functional/test_runner.py functional/wallet* # (called from the build/test/ directory) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the command line usually doesn't interpret these as comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bash does, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same Bash style for comments is used in other docs. So, it can be improved in a separated PR.
No description provided.