Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Improve summary output about ccache #325

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Aug 12, 2024

  1. From build: Introduce CMake-based build system bitcoin/bitcoin#30454 (comment):

I think we can improve the output when -DWITH_CCACHE=OFF is used. Depending on the system, that output might be:

cmake -B build -DWITH_CCACHE=OFF
< snip >
Use ccache for compiling .............. ccache masquerades as the compiler

We should probably at least indicate that the option was respected by the build-system.

With this PR on Fedora 40:

$ cmake -B build -DWITH_CCACHE=OFF
< snip >
Use ccache for compiling .............. ON


  ******

CMake Warning at CMakeLists.txt:656 (message):
  Disabling ccache was attempted using -DWITH_CCACHE=OFF, but ccache
  masquerades as the compiler.


  ******
  1. The second commit fixes a bug introduced in cmake: Implement prefix maps #298.

Apply prefix map flags only when ccache is used, which mirrors the
behavior in the master branch.
@hebasto hebasto added the bug Something isn't working label Aug 12, 2024
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit a681714 into cmake-staging Aug 15, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants