Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use ModuleHandlerInterface instead of ModuleHandler #4333

Closed
esolitos opened this issue Sep 7, 2022 · 0 comments · Fixed by #4334
Closed

fix: Use ModuleHandlerInterface instead of ModuleHandler #4333

esolitos opened this issue Sep 7, 2022 · 0 comments · Fixed by #4334

Comments

@esolitos
Copy link

esolitos commented Sep 7, 2022

Currently the implementation of Update/ExecuteComamnd relies on ModuleHandler, however some modules might want to decorate/replace this service so the class name won't match.

drupal-console/src/Command/Update/ExecuteCommand.php

Line 80 in d292c94

ModuleHandler $moduleHandler,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use service interfaces, not specific implementations. esolitos/drupal-console
1 participant
@esolitos