Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album sorting does not work correctly #35

Closed
srasher opened this issue Mar 28, 2014 · 4 comments
Closed

Album sorting does not work correctly #35

srasher opened this issue Mar 28, 2014 · 4 comments
Labels

Comments

@srasher
Copy link

srasher commented Mar 28, 2014

I am using v0.3.6. In the Google Music plugin preferences in LMS I have set the album sorting to "Interpret, Year, Album". This basically works, but the sorting by year does not always work correctly. I have attached a screenshot were you can see that the four albums from "Amon Amarth" are sorted rather strangely. This happens for "My Music" as well as for "All inclusive" searches.

Let me stress that this is a very minor issue :-) I just wanted to start to help/support the development of this FANTASTIC plugin!

Cheers,
Seb
lms-google-music-plugin__album-sorting-issue

@hechtus hechtus changed the title Album sorting does not work correctly (minor issue) Album sorting does not work correctly Mar 29, 2014
@hechtus hechtus added the bug label Mar 29, 2014
@hechtus
Copy link
Owner

hechtus commented Mar 29, 2014

You are right! I were confused by the Perl "or" operators. Thanks for reporting.

@hechtus
Copy link
Owner

hechtus commented Apr 12, 2014

Just released v0.3.7. Please check, if it's working for you now.

@srasher
Copy link
Author

srasher commented Apr 16, 2014

Sorry for the delayed answer, was offline for some days. In general the issue is fixed, Interpret-Year-Album sorting is now more consistent. The only minor flaw is that it is sorted by year in descending order. This is not necessarily wrong/bad, it is just the opposite way than the sorting in LMS'ses local lib browsing. No need to change from my side for the moment...

@hechtus
Copy link
Owner

hechtus commented Apr 17, 2014

I simply favored the descending order. It's quite convenient to play the most recent albums. There is also a possibility to add a plugin option for this. Lets see, if others would also like this idea. For now I would like to keep it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants