-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor icon support through Game trait #112
Merged
hecrj
merged 7 commits into
hecrj:improvement/new-winit-event-loop
from
oguzkocer:feature/cursor-icon
Oct 26, 2019
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
42aa6a3
WIP cursor icon support through Game trait
oguzkocer 9a2fbed
Update cursor icon in Game only if it's changed
oguzkocer b60a31f
Update cursor icon in UserInterface by taking game cursor into account
oguzkocer 13429f2
Simplifies cursor update logic across modules
oguzkocer 66828da
Implements TryFrom for CursorIcon and uses Option for cursor icon cac…
oguzkocer 21ce46f
Adds documentation for cursor icon
oguzkocer 6b7cced
Updates CHANGELOG to include game::cursor_icon addition
oguzkocer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
use crate::graphics::window::winit; | ||
use std::convert::TryFrom; | ||
|
||
/// Describes the appearance of the mouse cursor. | ||
#[derive(Debug, Clone, Copy, PartialEq)] | ||
pub enum CursorIcon { | ||
/// The platform-dependent default cursor. | ||
Default, | ||
/// A simple crosshair. | ||
Crosshair, | ||
/// A hand (often used to indicate links in web browsers). | ||
Hand, | ||
/// Hides the cursor. | ||
Hidden, | ||
/// Indicates something is to be moved. | ||
Move, | ||
} | ||
|
||
impl Default for CursorIcon { | ||
fn default() -> Self { | ||
Self::Default | ||
} | ||
} | ||
|
||
impl TryFrom<CursorIcon> for winit::window::CursorIcon { | ||
type Error = (); | ||
|
||
fn try_from( | ||
cursor_icon: CursorIcon, | ||
) -> Result<winit::window::CursorIcon, ()> { | ||
match cursor_icon { | ||
CursorIcon::Default => Ok(winit::window::CursorIcon::Default), | ||
CursorIcon::Crosshair => Ok(winit::window::CursorIcon::Crosshair), | ||
CursorIcon::Hand => Ok(winit::window::CursorIcon::Hand), | ||
CursorIcon::Hidden => Err(()), | ||
CursorIcon::Move => Ok(winit::window::CursorIcon::Move), | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, we can make this take an
Option<winit::Window::CursorIcon>
and removeset_cursor_visible
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 66828da.