Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update winit and wgpu #62

Merged
merged 19 commits into from
Apr 24, 2020
Merged

Update winit and wgpu #62

merged 19 commits into from
Apr 24, 2020

Conversation

hecrj
Copy link
Owner

@hecrj hecrj commented Jul 2, 2019 •
edited
Loading

Depends on #60.

Added

  • The new game::Loop trait. It removes code duplication in UserInterface::run.

Changed

  • Updated wgpu to 0.5.0.
  • Updated wgpu_glyph to 0.8.0.
  • Updated winit to 0.22.

@hecrj
Migrate to the new winit event loop.
fd599ae 
- The new `game::Loop` trait is introduced to remove code duplication in
  `UserInterface::run`.
- The `empty` feature is introduced, it allows testing without a
  specific backend enabled.
@hecrj hecrj added the improvement An internal improvement label Jul 2, 2019
@hecrj hecrj self-assigned this Jul 2, 2019
@hecrj hecrj mentioned this pull request Jul 2, 2019
Draft
26 tasks
@hecrj hecrj added this to the 0.4.0 milestone Jul 7, 2019
@hecrj hecrj mentioned this pull request Jul 8, 2019
Closed
@hecrj hecrj mentioned this pull request Aug 21, 2019
Open
@hecrj hecrj marked this pull request as ready for review August 25, 2019 00:36
@hecrj hecrj mentioned this pull request Sep 3, 2019
Open
3 tasks
@oguzkocer oguzkocer mentioned this pull request Oct 20, 2019
Closed
hecrj
hecrj commented Oct 21, 2019
View reviewed changes
src/graphics/backend_wgpu/texture.rs
@@ -293,11 +293,11 @@ fn create_texture_array(
let view = texture.create_view(&wgpu::TextureViewDescriptor {
format: wgpu::TextureFormat::Bgra8UnormSrgb,
dimension: wgpu::TextureViewDimension::D2Array,
aspect: wgpu::TextureAspectFlags::COLOR,
aspect: wgpu::TextureAspect::All,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure about this one.

@hecrj hecrj changed the title Use new winit event loop Update winit and wgpu Apr 24, 2020
@hecrj
Copy link
Owner Author

hecrj commented Apr 24, 2020 •
edited
Loading

Today coffee turns 1 year old! 🎉

I have updated winit and wgpu to the latest version. I know it's been outdated for a while, but better late than never.

@hecrj hecrj merged commit aaaaf55 into master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkocer oguzkocer oguzkocer left review comments

Assignees

@hecrj hecrj

Labels
improvement An internal improvement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hecrj @oguzkocer