Remove default stable install on Windows #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, even though we call
rustup set profile minimal
, Windows still downloads and installs therust-docs
component. This is because GitHub's default rustup install comes with thestable
toolchain installed under the default profile, which containsrust-docs
, resulting in rustup updating therust-docs
component despite our request otherwise. This PR removes the default stable Rust install, speeding up the Rust install process from about 3 minutes to 30 seconds.Note that this PR simply moves the rustup toolchain folder to a new location, rather than calling
rustup toolchain uninstall stable
. This is because the official uninstall method removes all the rust documentation files from the filesystem, which takes a while. Using that rather than the method presented here takes 2 minutes, which is still faster than the status quo but significantly slower than this PR.