Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default stable install on Windows #11

Merged
merged 4 commits into from
Dec 4, 2019

Conversation

Osspial
Copy link
Contributor

@Osspial Osspial commented Dec 4, 2019

Right now, even though we call rustup set profile minimal, Windows still downloads and installs the rust-docs component. This is because GitHub's default rustup install comes with the stable toolchain installed under the default profile, which contains rust-docs, resulting in rustup updating the rust-docs component despite our request otherwise. This PR removes the default stable Rust install, speeding up the Rust install process from about 3 minutes to 30 seconds.

Note that this PR simply moves the rustup toolchain folder to a new location, rather than calling rustup toolchain uninstall stable. This is because the official uninstall method removes all the rust documentation files from the filesystem, which takes a while. Using that rather than the method presented here takes 2 minutes, which is still faster than the status quo but significantly slower than this PR.

@hecrj hecrj added the enhancement New feature or request label Dec 4, 2019
@hecrj
Copy link
Owner

hecrj commented Dec 4, 2019

Thanks @Osspial!

Does the issue you describe also affect Ubuntu? Maybe we should implement a similar fix for it too.

@hecrj hecrj merged commit a6bcfcc into hecrj:master Dec 4, 2019
@Osspial
Copy link
Contributor Author

Osspial commented Dec 4, 2019

It looks like Ubuntu also has rust-docs installed by default, but it's significantly less of an issue there because rust-docs takes much less time to manage. The solution here should largely work for Ubuntu, except you'd need to use whereis instead of where to get the .cargo path.

@hecrj hecrj mentioned this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants