Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidecar syntax issues #193

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix sidecar syntax issues #193

merged 3 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Check for non-existent HED in referenced splice columns in sidecar va… 

    …lidation

Also use TSV file for merged sidecar object.
    @happy5214
    happy5214 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a2dceef View commit details
    Browse the repository at this point in the history

  2. Fix nested HED / n/a issues and convert some plain errors to IssueError 

    Also adjust JSON spec tests to use IssueErrors thrown by BidsSidecar
and BidsTsvFile constructors.
    @happy5214
    happy5214 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a6ff876 View commit details
    Browse the repository at this point in the history

  3. Pass actual mock file objects from JSON spec tests instead of null 

    Passing null was causing null pointer errors in the validation, which
was the source of the failing invalid SIDECAR_KEY_MISSING test.
    @happy5214
    happy5214 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    558f97e View commit details
    Browse the repository at this point in the history