Refactor schema parsing code #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tag/attribute parser is now contained in three classes, and the SchemaAttributes class has been moved to another class in the interim until the new entity classes are created.
happy5214
force-pushed
the
schema-entities
branch
from
3216727 to
8d70559
Compare
tagHasAttribute is now piped through Schema to help promote clarity and avoid null-pointer errors. As part of this commit, the dataset tests have been upgraded to the stable v8.0.0 HED schema.
…stead of schema creation issue
happy5214
force-pushed
the
schema-entities
branch
from
a5b9522 to
8f3999f
Compare
Also use new issue return format, thereby fixing #48.
This was
linked to
issues
Apr 27, 2022
Also fix bug that prevented string parsing issues from being returned from dataset validation.
This commit reorganizes the event file sidecar data into a pseudo BidsSidecar object, while moving much of the general parsing of sidecar data to that class. It also uses the new entry point from the previous commit.
This was
linked to
issues
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag/attribute parser is now contained in three classes, and the
SchemaAttributes class has been moved to another class in the interim
until the new entity classes are created.